zzbennett commented on code in PR #20061: URL: https://github.com/apache/kafka/pull/20061#discussion_r2191438834
########## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorMetadataImage.java: ########## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.common.runtime; + +import org.apache.kafka.common.Uuid; + +import java.util.List; +import java.util.Optional; +import java.util.Set; + +/** + * Provides metadata to Coordinators (GroupCoordinator, ShareCoordinator, etc) such as topics, partitions, and their configurations. + * Implementations should be thread-safe and immutable. + */ +public interface CoordinatorMetadataImage { + CoordinatorMetadataImage EMPTY = emptyImage(); + + Optional<String> topicName(Uuid id); + + Optional<Uuid> topicId(String topicName); + + default Optional<Integer> partitionCount(Uuid topicId) { + var topicName = topicName(topicId); + return topicName.isEmpty() ? Optional.empty() : partitionCount(topicName.get()); + } + + Optional<Integer> partitionCount(String topicName); + + Set<Uuid> topicIds(); + + Set<String> topicNames(); + + Optional<TopicMetadata> topicMetadata(String topicName); + + default Optional<TopicMetadata> topicMetadata(Uuid topicId) { + var topicName = topicName(topicId); + return topicName.isEmpty() ? Optional.empty() : topicMetadata(topicName.get()); Review Comment: No particular reason. This is moot now though because I removed `topicName()` from the top-level interface, so the underlying impls would need to implement both the name and Uuid version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
