zzbennett commented on code in PR #20061:
URL: https://github.com/apache/kafka/pull/20061#discussion_r2191446948
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -2139,7 +2139,7 @@ public void onPartitionsDeleted(
// At this point the metadata will not have been updated
// with the deleted topics.
Set<Uuid> topicIds = topicPartitions.stream()
- .map(tp -> metadataImage.topics().getTopic(tp.topic()).id())
+ .map(tp ->
metadataImage.topicId(tp.topic()).orElse(Uuid.ZERO_UUID))
Review Comment:
I guess there is maybe the theoretical case where the `topicPartitions` that
was passed in contains topics that don't exist in the metadata (the comment
seems to indicate this won't happen though). But I can just return `null` since
that is the existing behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
