Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2233067242


##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##########
@@ -2998,15 +2993,6 @@ private void 
verifyVersionedTaskConverterFromWorker(String converterClassConfig,
         verify(plugins).newConverter(any(WorkerConfig.class), 
eq(converterClassConfig), eq(converterVersionConfig));
     }
 
-    private void mockTaskHeaderConverter(ClassLoaderUsage classLoaderUsage, 
HeaderConverter returning) {

Review Comment:
   same applies for the fields, its a general decision to be made. Let me know 
if i should undo them too. Kindly request your critics again, thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to