Pankraz76 commented on PR #20219: URL: https://github.com/apache/kafka/pull/20219#issuecomment-3121737804
> The PR is marked as "[Experimental]" but makes changes that would affect all developers immediately. This includes modifying the main build configuration, adding new required tasks to the check lifecycle, enabling build caching globally, and changing existing tool configurations. For an experimental feature, I'd suggest using a separate build file or opt-in flag instead. It would also be helpful to create a feature branch for testing, provide a way to disable the rewrite checks, and add proper documentation about the experimental nature of these changes. Maybe `[PoC]` would reflect my intention better as this is just some suggestion offered. It needs to be wanted and pulled by the dev team, as it's a conventional change, not designed to opt in, as the nature of this can be (once) invasive and is meant to sustain therefore be constantly checked against. Same approach like spot but more flexible. I would suggest to make a decision about using the potential benefit this tool has to offer and then integrate it non-breaking/colliding with anything of course, making it ready (opt-in/out) to be removed afterwards again, if it turns out, not to be practical. The import statement is a good starter and the removals as they should flag only once and non-critical stuff as overhead is normally obsolete, ready to be reconsidered and resolved. As the task is meant to run in cloud only it's about time and stability, as the recipes are individual. Only the dev teams choose which to leverage and apply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
