Pankraz76 commented on code in PR #20219: URL: https://github.com/apache/kafka/pull/20219#discussion_r2232847588
########## build.gradle: ########## @@ -29,18 +34,77 @@ buildscript { } plugins { - id 'com.github.ben-manes.versions' version '0.48.0' - id 'idea' - id 'jacoco' - id 'java-library' - id 'org.owasp.dependencycheck' version '8.2.1' - id 'org.nosphere.apache.rat' version "0.8.1" + id "com.diffplug.spotless" version "7.2.1" + id "com.github.ben-manes.versions" version "0.48.0" + id "com.github.spotbugs" version "6.0.25" apply false + id "com.gradleup.shadow" version "8.3.6" apply false + id "idea" id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}" + id "jacoco" + id "java-library" + id "org.nosphere.apache.rat" version "0.8.1" + id "org.openrewrite.rewrite" version "7.12.1" + id "org.owasp.dependencycheck" version "8.2.1" + id "org.scoverage" version "8.0.3" apply false +} + +rewrite { + activeRecipe( + "org.openrewrite.gradle.GradleBestPractices", + "org.openrewrite.java.RemoveUnusedImports", + "org.openrewrite.staticanalysis.RemoveUnusedLocalVariables", + "org.openrewrite.staticanalysis.RemoveUnusedPrivateFields", + "org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods", + //"org.openrewrite.java.OrderImports", + //"org.openrewrite.java.format.RemoveTrailingWhitespace", + //"org.openrewrite.java.migrate.UpgradeToJava17", + //"org.openrewrite.java.migrate.util.MigrateCollectionsSingletonList", + //"org.openrewrite.java.migrate.util.MigrateCollectionsUnmodifiableList", + //"org.openrewrite.java.recipes.JavaRecipeBestPractices", + //"org.openrewrite.java.recipes.RecipeNullabilityBestPractices", + //"org.openrewrite.java.recipes.RecipeTestingBestPractices", + //"org.openrewrite.staticanalysis.CodeCleanup", + //"org.openrewrite.staticanalysis.EmptyBlock", + //"org.openrewrite.staticanalysis.EqualsAvoidsNull", + //"org.openrewrite.staticanalysis.JavaApiBestPractices", + //"org.openrewrite.staticanalysis.MissingOverrideAnnotation", + //"org.openrewrite.staticanalysis.ModifierOrder", + //"org.openrewrite.staticanalysis.NoFinalizer", + //"org.openrewrite.staticanalysis.RemoveCallsToSystemGc", + //"org.openrewrite.staticanalysis.RemoveUnneededAssertion", + //"org.openrewrite.staticanalysis.StringLiteralEquality", + //"org.openrewrite.staticanalysis.UnnecessaryParentheses", + //"org.openrewrite.staticanalysis.UnnecessaryThrows", + //"org.openrewrite.text.EndOfLineAtEndOfFile", + //"tech.picnic.errorprone.refasterrules.CollectionRulesRecipes", + //"tech.picnic.errorprone.refasterrules.FileRulesRecipes", + //"tech.picnic.errorprone.refasterrules.NullRulesRecipes", + //"tech.picnic.errorprone.refasterrules.NullRulesRecipes", + //"tech.picnic.errorprone.refasterrules.StreamRulesRecipes", + //"tech.picnic.errorprone.refasterrules.StringRulesRecipes", + // running active recipes: tech.picnic.errorprone.refasterrules.NullRulesRecipes + //<============-> 99% EXECUTING [1h 38s] Review Comment: thanks for executing, yes this is really an burden. Lets shirt this into an dedicated PR once the foundation is set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org