chia7712 commented on code in PR #20405:
URL: https://github.com/apache/kafka/pull/20405#discussion_r2300212368
##########
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##########
@@ -1599,31 +1622,37 @@ class TestMetricsReporter extends MetricsReporter with
Reconfigurable with Close
}
override def reconfigurableConfigs(): util.Set[String] = {
- util.Set.of(PollingIntervalProp)
+ util.Set.of(PollingIntervalProp,
ReplicationConfigs.NUM_REPLICA_FETCHERS_CONFIG)
Review Comment:
@FrankYang0529 Thanks for your help. Could you please consider creating an
individual metrics reporter for the new test? Including too many test cases in
`TestMetricsReporter` could make it harder to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
