chia7712 commented on code in PR #20405:
URL: https://github.com/apache/kafka/pull/20405#discussion_r2300672256
##########
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##########
@@ -1634,6 +1655,86 @@ class TestMetricsReporter extends MetricsReporter with
Reconfigurable with Close
}
}
+object TestNumReplicaFetcherMetricsReporter {
+ val testReporters = new
ConcurrentLinkedQueue[TestNumReplicaFetcherMetricsReporter]()
+ val configuredBrokers = mutable.Set[Int]()
+
+ def waitForReporters(count: Int): List[TestNumReplicaFetcherMetricsReporter]
= {
+ TestUtils.waitUntilTrue(() => testReporters.size == count, msg = "Metrics
reporters size not matched. Expected: " + count + ", actual: " +
testReporters.size())
+
+ val reporters = testReporters.asScala.toList
+ TestUtils.waitUntilTrue(() => reporters.forall(_.configureCount == 1), msg
= "Metrics reporters not configured")
+ reporters
+ }
+}
+
+
+class TestNumReplicaFetcherMetricsReporter extends MetricsReporter with
Reconfigurable with Closeable with ClusterResourceListener {
Review Comment:
The reporter's functionality is excessive. All we need to verify is that is
can "see" the latest configurations at startup. Therefore, only
`reconfigureCount` is relevant for the new test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
