Yunyung commented on code in PR #20405: URL: https://github.com/apache/kafka/pull/20405#discussion_r2300305549
########## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ########## @@ -1568,6 +1589,7 @@ class TestMetricsReporter extends MetricsReporter with Reconfigurable with Close @volatile var closeCount = 0 @volatile var clusterUpdateCount = 0 @volatile var pollingInterval: Int = -1 + @volatile var numFetchers: Int = 1 Review Comment: Please ignore this. For this reason: https://issues.apache.org/jira/browse/KAFKA-19645 , it is probably more reasonable to keep it as 1 instead setting invalid value. ########## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ########## @@ -1568,6 +1589,7 @@ class TestMetricsReporter extends MetricsReporter with Reconfigurable with Close @volatile var closeCount = 0 @volatile var clusterUpdateCount = 0 @volatile var pollingInterval: Int = -1 + @volatile var numFetchers: Int = 1 Review Comment: Please ignore this. For this reason: https://issues.apache.org/jira/browse/KAFKA-19645 , it is probably more reasonable to keep it as 1 instead of setting invalid value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
