mjsax commented on code in PR #20605:
URL: https://github.com/apache/kafka/pull/20605#discussion_r2386497159
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java:
##########
@@ -891,7 +891,10 @@ protected static Topology getTopology(final Properties
streamsConfig,
rejoin,
leftVersioned,
rightVersioned,
- value -> value.split("\\|")[1]
+ value -> {
+ final String[] tokens = value.split("\\|");
+ return tokens.length == 2 ? tokens[1] : null;
+ }
Review Comment:
Some side cleanup... While playing with the code adding other test (which I
removed later, as they were just for myself), this method failed if we did only
get one token...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
