mjsax commented on code in PR #20605:
URL: https://github.com/apache/kafka/pull/20605#discussion_r2388349078
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionReceiveProcessorSupplier.java:
##########
@@ -82,7 +82,8 @@ public void init(final ProcessorContext<CombinedKey<KRight,
KLeft>, Change<Value
@Override
public void process(final Record<KRight,
SubscriptionWrapper<KLeft>> record) {
- if (record.key() == null &&
!SubscriptionWrapper.Instruction.PROPAGATE_NULL_IF_NO_FK_VAL_AVAILABLE.equals(record.value().instruction()))
{
+ final KRight foreignKey = record.key();
Review Comment:
Happy to rename, but don't think it does buy us too much, as it clear from
the class name and parameter type that it's a subscription record. But renaming
does not help much to explain how a subscription record built up internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
