mjsax commented on code in PR #20605:
URL: https://github.com/apache/kafka/pull/20605#discussion_r2386499441
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java:
##########
@@ -128,47 +128,101 @@ public void process(final Record<KLeft, Change<VLeft>>
record) {
}
private void leftJoinInstructions(final Record<KLeft, Change<VLeft>>
record) {
Review Comment:
The diff is unfortunately a little bit messy, but if you compare new and old
code, also because I added comments, it should become clear the the new code is
much cleaner, especially for left-join case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
