bbejeck commented on code in PR #20570:
URL: https://github.com/apache/kafka/pull/20570#discussion_r2375749474
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##########
@@ -281,6 +281,15 @@ public void shouldPassMetrics(final String topologyType,
final String groupProto
streamsApplicationProperties = props(groupProtocol);
final Topology topology = topologyType.equals("simple") ?
simpleTopology(false) : complexTopology();
+ shouldPassMetrics(topology);
+
+ INTERCEPTING_CONSUMERS.clear();
+ INTERCEPTING_ADMIN_CLIENTS.clear();
+
+ shouldPassMetrics(topology);
+ }
+
+ private void shouldPassMetrics(Topology topology) throws Exception {
Review Comment:
`topology` needs to be final
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##########
@@ -281,6 +281,15 @@ public void shouldPassMetrics(final String topologyType,
final String groupProto
streamsApplicationProperties = props(groupProtocol);
final Topology topology = topologyType.equals("simple") ?
simpleTopology(false) : complexTopology();
+ shouldPassMetrics(topology);
+
+ INTERCEPTING_CONSUMERS.clear();
+ INTERCEPTING_ADMIN_CLIENTS.clear();
+
+ shouldPassMetrics(topology);
Review Comment:
Why do we validate the metrics, clear the clients list, then validate again?
I'm not opposed to this I just want to understand what's going on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
