lianetm commented on code in PR #19885:
URL: https://github.com/apache/kafka/pull/19885#discussion_r2491976458
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -694,6 +694,29 @@ public void
testOffsetFetchRequestEnsureDuplicatedRequestSucceed() {
assertEmptyPendingRequests(commitRequestManager);
}
+ @Test
+ public void testOffsetFetchRequestShouldSucceedWithTopicId() {
Review Comment:
this is nice, but we're still missing coverage for the core change right?
(request builder using topic IDs if available)
I expect we actually need to look into the generated request returned by
poll, and validate the 2 core cases:
- request generated with v<10 and topic names (if topic IDs not in metadata)
- request generated with v >=10 and topic IDs (if topic IDs in metadata)
Makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
