DL1231 commented on code in PR #19885:
URL: https://github.com/apache/kafka/pull/19885#discussion_r2536009271
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -751,6 +751,59 @@ public void
testOffsetFetchRequestEnsureDuplicatedRequestSucceed() {
assertEmptyPendingRequests(commitRequestManager);
}
+ @Test
+ public void testOffsetFetchRequestShouldSucceedWithTopicId() {
+ CommitRequestManager commitRequestManager = create(true, 100);
+
when(coordinatorRequestManager.coordinator()).thenReturn(Optional.of(mockedNode));
+ Uuid topicId = Uuid.randomUuid();
+ when(metadata.topicIds()).thenReturn(Map.of("t1", topicId));
+ when(metadata.topicNames()).thenReturn(Map.of(topicId, "t1"));
+ Set<TopicPartition> partitions = new HashSet<>();
+ partitions.add(new TopicPartition("t1", 0));
+
+ List<CompletableFuture<Map<TopicPartition, OffsetAndMetadata>>>
futures = sendAndVerifyDuplicatedOffsetFetchRequests(
+ commitRequestManager,
+ partitions,
+ 2,
+ Errors.NONE,
+ true,
+ topicId);
+ futures.forEach(f -> {
+ assertTrue(f.isDone());
+ assertFalse(f.isCompletedExceptionally());
+ });
+ // expecting the buffers to be emptied after being completed
successfully
+ commitRequestManager.poll(0);
+ assertEmptyPendingRequests(commitRequestManager);
+ }
+
+ @Test
+ public void
testOffsetFetchRequestShouldFailedWithTopicIdWhenMetadataUnknownResponseTopicId()
{
+ CommitRequestManager commitRequestManager = create(true, 100);
+
when(coordinatorRequestManager.coordinator()).thenReturn(Optional.of(mockedNode));
+ Uuid topicId = Uuid.randomUuid();
+ when(metadata.topicIds()).thenReturn(Map.of("t1", topicId));
+ // Mock the scenario where the topicID from the response is not in the
metadata.
+ when(metadata.topicNames()).thenReturn(Map.of());
+ Set<TopicPartition> partitions = new HashSet<>();
+ partitions.add(new TopicPartition("t1", 0));
+
+ List<CompletableFuture<Map<TopicPartition, OffsetAndMetadata>>>
futures = sendAndVerifyDuplicatedOffsetFetchRequests(
+ commitRequestManager,
+ partitions,
+ 2,
+ Errors.NONE,
+ true,
+ topicId);
+ futures.forEach(f -> {
+ assertTrue(f.isDone());
+ assertTrue(f.isCompletedExceptionally());
+ });
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
