lianetm commented on code in PR #19885:
URL: https://github.com/apache/kafka/pull/19885#discussion_r2528122589
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -1124,9 +1123,11 @@ private void onSuccess(final long currentTimeMs,
var failedRequestRegistered = false;
for (var topic : response.topics()) {
+ // If the topic id is used, the topic name is empty in the
response.
+ String topicName = topic.name().isEmpty() ?
metadata.topicNames().get(topic.topicId()) : topic.name();
Review Comment:
after this, we could still have empty `topicName` if the `topicID` from the
response is not in the metadata anymore right? And in this case of OffsetFetch
that would be problematic because we do need a topic name to return along with
the offsets.
One option that comes to mind is to fail in the same way we do when we get
`UNKNOWN_TOPIC_ID` , failing the future with "topic does not exist" (ln 1143).
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
