see-quick commented on code in PR #21384:
URL: https://github.com/apache/kafka/pull/21384#discussion_r2773041921
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -79,6 +79,7 @@ public abstract class AbstractKafkaConfig extends
AbstractConfig {
QuorumConfig.CONFIG_DEF,
MetricConfigs.CONFIG_DEF,
QuotaConfig.CONFIG_DEF,
+ QuotaConfig.BROKER_QUOTA_CONFIG_DEF,
Review Comment:
> I think it's still beneficial to document them. The updates in
[KAFKA-20125](https://issues.apache.org/jira/browse/KAFKA-20125) will remind
users that these configs are dynamic-only.
Yeah, sure.
> We could modify the config generation logic instead of adding them to
AbstractKafkaConfig.CONFIG_DEF.
I wonder if modifying directly into
https://github.com/apache/kafka/blob/4783f6ad1f8e6237fd92a8dbf284cfcdd7365d9b/core/src/main/scala/kafka/server/KafkaConfig.scala#L58-L61
we can do something like I assume (are you fine with such approach?):
```scala
def main(args: Array[String]): Unit = {
val combined = new ConfigDef(configDef)
QuotaConfig.brokerQuotaConfigs().configKeys().forEach((_, v) =>
combined.define(v))
System.out.println(combined.toHtml(4, (config: String) =>
"brokerconfigs_" + config,
JDynamicBrokerConfig.dynamicConfigUpdateModes))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
