mjsax commented on code in PR #21503:
URL: https://github.com/apache/kafka/pull/21503#discussion_r2820242009
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStoreWithHeaders.java:
##########
@@ -139,7 +139,7 @@ private void openInRegularMode(final DBOptions dbOptions,
}
private void verifyAndCloseEmptyDefaultColumnFamily(final
ColumnFamilyHandle columnFamilyHandle) {
- try (final RocksIterator defaultIter =
db.newIterator(columnFamilyHandle)) {
+ try (columnFamilyHandle; final RocksIterator defaultIter =
db.newIterator(columnFamilyHandle)) {
Review Comment:
Follow up fix for https://github.com/apache/kafka/pull/21446 (did not want
to leave a comment to be able to merge the PR -- I think we need to close the
CF-handle here -- otherwise it would leak).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
