mjsax commented on code in PR #21503:
URL: https://github.com/apache/kafka/pull/21503#discussion_r2820268275
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStoreTest.java:
##########
@@ -163,34 +165,39 @@ public void
shouldMigrateDataFromDefaultToTimestampColumnFamily() throws Excepti
assertThat(rocksDBStore.approximateNumEntries(), is(5L));
// should add new key8 to new CF
- rocksDBStore.put(new Bytes("key8".getBytes()),
"timestamp+88888888".getBytes());
+ rocksDBStore.put(new Bytes("key8new".getBytes()),
"timestamp+88888888".getBytes());
Review Comment:
Aligning the naming to the newly added equivalent test for header store
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStoreTest.java:
##########
@@ -163,34 +165,39 @@ public void
shouldMigrateDataFromDefaultToTimestampColumnFamily() throws Excepti
assertThat(rocksDBStore.approximateNumEntries(), is(5L));
// should add new key8 to new CF
- rocksDBStore.put(new Bytes("key8".getBytes()),
"timestamp+88888888".getBytes());
+ rocksDBStore.put(new Bytes("key8new".getBytes()),
"timestamp+88888888".getBytes());
// one delete on old CF, one put on new CF
// approx: 3 entries on old CF, 2 in new CF
assertThat(rocksDBStore.approximateNumEntries(), is(5L));
+ rocksDBStore.put(new Bytes("key9new".getBytes()), null);
Review Comment:
Add missing test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
