mjsax commented on code in PR #21503:
URL: https://github.com/apache/kafka/pull/21503#discussion_r2820246725


##########
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStoreWithHeadersTest.java:
##########
@@ -174,19 +175,24 @@ public void 
shouldMigrateFromTimestampedToHeadersAwareColumnFamily() throws Exce
         // one delete on old CF, one put on new CF, but count is off by one 
due to delete on old CF not deleting anything
         assertEquals(5L, rocksDBStore.approximateNumEntries(), "Expected 3 
entries on legacy CF, 2 in headers-aware CF after adding new key8new with 
put()");
 
+        rocksDBStore.put(new Bytes("key9new".getBytes()), null);

Review Comment:
   Follow up to https://github.com/apache/kafka/pull/21446 -- Did not want to 
leave a comment there. The case for `put(newKey, null)` was missing, so added 
it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to