mjsax commented on code in PR #21768:
URL: https://github.com/apache/kafka/pull/21768#discussion_r2944177210
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreWithHeaders.java:
##########
@@ -105,13 +107,24 @@ protected Serde<ValueTimestampHeaders<V>>
prepareValueSerdeForStore(final Serde<
}
}
+ @Override
+ public ValueTimestampHeaders<V> get(final K key) {
+ Objects.requireNonNull(key, "key cannot be null");
+ try {
+ return maybeMeasureLatency(() ->
deserializeValue(wrapped().get(serializeKey(key, new RecordHeaders()))), time,
getSensor);
Review Comment:
SG -- seems it only affect `get()` -- so yes, it's the same as
`serializeKey(key)` but we make a conscious decision about it, what it desired.
I'll update it for `delete` can in the PR, too for now, but after
https://github.com/apache/kafka/pull/21639 is merged this will change (of if
Frank's PR is merged first, it will go away after rebasing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
