mjsax commented on code in PR #21768:
URL: https://github.com/apache/kafka/pull/21768#discussion_r2944232180
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreWithHeaders.java:
##########
@@ -125,14 +138,42 @@ public ValueTimestampHeaders<V> putIfAbsent(final K key,
Objects.requireNonNull(key, "key cannot be null");
final Headers headers = value != null ? value.headers() : new
RecordHeaders();
final ValueTimestampHeaders<V> currentValue = maybeMeasureLatency(
- () -> deserializeValue(wrapped().putIfAbsent(keyBytes(key,
headers), serdes.rawValue(value, headers))),
+ // `rawOldValue` returned from `wrapped().putIfAbsent(...)` is
type ValueTimestampHeader
+ // -> no need to pass in Headers into `deserializeValue()`
+ () -> deserializeValue(wrapped().putIfAbsent(serializeKey(key,
headers), serdes.rawValue(value, headers))),
time,
putIfAbsentSensor
);
maybeRecordE2ELatency();
return currentValue;
}
+ @Override
+ public void putAll(final List<KeyValue<K, ValueTimestampHeaders<V>>>
entries) {
+ entries.forEach(entry -> Objects.requireNonNull(entry.key, "key cannot
be null"));
+ maybeMeasureLatency(() -> wrapped().putAll(innerEntries(entries)),
time, putAllSensor);
+ }
+
+ private List<KeyValue<Bytes, byte[]>> innerEntries(final List<KeyValue<K,
ValueTimestampHeaders<V>>> from) {
+ final List<KeyValue<Bytes, byte[]>> byteEntries = new ArrayList<>();
+ for (final KeyValue<K, ValueTimestampHeaders<V>> entry : from) {
+ final Headers headers = entry.value != null ?
entry.value.headers() : new RecordHeaders();
+ byteEntries.add(KeyValue.pair(serializeKey(entry.key, headers),
serializeValue(entry.value)));
Review Comment:
It's doesn't really matter, because for the header-case the passed in
headers are ignored -- but yes, there is some code inconsistency... Let me
unify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
