mjsax commented on code in PR #21768:
URL: https://github.com/apache/kafka/pull/21768#discussion_r2944293611
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##########
@@ -449,7 +449,7 @@ protected Bytes serializeKey(final K key) {
}
protected K deserializeKey(final byte[] rawKey) {
- return rawKey != null ? serdes.keyFrom(rawKey,
internalContext.headers()) : null;
+ return serdes.keyFrom(rawKey, internalContext.headers());
Review Comment:
The key can actually never be `null` -- this would be bug that we should not
mask by a nul-check but surface directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
