chia7712 commented on code in PR #21771:
URL: https://github.com/apache/kafka/pull/21771#discussion_r3256529148
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -803,18 +844,25 @@ private static void evaluateValues(
/**
* Log a WARN if the session timeout is not greater than the heartbeat
interval after
- * evaluation. When a key is absent from props, the broker-level default
is used.
+ * evaluation. When a key is absent from newGroupConfig, the broker-level
default is used.
+ *
+ * @param newGroupConfig The new unparsed group config overrides.
+ * @param groupId The group id.
+ * @param sessionKey The session timeout config key.
+ * @param defaultSession The default session timeout value when
there is no override.
+ * @param heartbeatKey The heartbeat interval config key.
+ * @param defaultHeartbeat The default heartbeat interval value when
there is no override.
*/
private static void checkSessionExceedsHeartbeat(
- Properties props,
+ Properties newGroupConfig,
Review Comment:
I'm trying not to be so nitpicky today :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
