dongnuo123 commented on code in PR #22457:
URL: https://github.com/apache/kafka/pull/22457#discussion_r3351554013
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1394,6 +1394,34 @@ private void validateOnlineUpgrade(ClassicGroup
classicGroup) {
}
}
+ /**
+ * Validates whether a new classic member is allowed to join the consumer
group.
+ * If the migration policy is disabled, the join request will be rejected,
unless
+ * the classic member is static and it replaces an existing consumer
member in
+ * the consumer group.
Review Comment:
Not too sure about this exception here. We have an existing unit test
`testJoiningConsumerGroupReplacingExistingStaticMember` that test this path
with disabled policy so we still allow this case here
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1394,6 +1394,34 @@ private void validateOnlineUpgrade(ClassicGroup
classicGroup) {
}
}
+ /**
+ * Validates whether a new classic member is allowed to join the consumer
group.
+ * If the migration policy is disabled, the join request will be rejected,
unless
+ * the classic member is static and it replaces an existing consumer
member in
+ * the consumer group.
Review Comment:
Not too sure about it here. We have an existing unit test
`testJoiningConsumerGroupReplacingExistingStaticMember` that test this path
with disabled policy so we still allow this case here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
