dajac commented on code in PR #22457:
URL: https://github.com/apache/kafka/pull/22457#discussion_r3388853021
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1394,6 +1394,23 @@ private void validateOnlineUpgrade(ClassicGroup
classicGroup) {
}
}
+ /**
Review Comment:
Should we update the documentation of ConsumerGroupMigrationPolicy to
clearly state that disabling it will kick out consumers from mixed groups?
##########
core/src/test/scala/unit/kafka/server/ConsumerProtocolMigrationTest.scala:
##########
@@ -395,7 +395,7 @@ class ConsumerProtocolMigrationTest(cluster:
ClusterInstance) extends GroupCoord
new ClusterConfigProperty(key =
GroupCoordinatorConfig.CONSUMER_GROUP_MIGRATION_POLICY_CONFIG, value =
"disabled")
)
)
- def testDowngradeWithDisabledMigrationPolicy(): Unit = {
Review Comment:
Not sure what we were thinking when we added this test. It looks weird. Do
we still have coverage for the downgrade case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
