dongnuo123 commented on code in PR #22457:
URL: https://github.com/apache/kafka/pull/22457#discussion_r3359580004
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1394,6 +1394,34 @@ private void validateOnlineUpgrade(ClassicGroup
classicGroup) {
}
}
+ /**
+ * Validates whether a new classic member is allowed to join the consumer
group.
+ * If the migration policy is disabled, the join request will be rejected,
unless
+ * the classic member is static and it replaces an existing consumer
member in
+ * the consumer group.
Review Comment:
It depends on whether we treat replacing a static member as "rejoin". It
kind of sounds like a rejoin to me but on the other hand, we reject the mirror
case (a new static consumer member can't replace an existing static classic
member in a classic group if upgrade is disabled) so updated the PR to reject
this case as well for symmetry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
