lucasbru commented on code in PR #22551:
URL: https://github.com/apache/kafka/pull/22551#discussion_r3413064751
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -643,6 +670,8 @@ public CompletableFuture<StreamsGroupHeartbeatResult>
streamsGroupHeartbeat(
.setErrorCode(error.code())
.setErrorMessage(message),
Map.of(),
+ -1,
Review Comment:
I wonder if it could make sense to define a direct constructor for error
messages for StreamsGroupHeartbeatResult, as we see to always set "Map.of(),
-1, -1, -1" in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
