lucasbru commented on code in PR #22551: URL: https://github.com/apache/kafka/pull/22551#discussion_r3415120343
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamGroupTopologyDescriptionManager.java: ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.streams; + +import org.apache.kafka.common.message.StreamsGroupHeartbeatResponseData; +import org.apache.kafka.common.protocol.Errors; +import org.apache.kafka.common.requests.StreamsGroupHeartbeatResponse.Status; +import org.apache.kafka.common.utils.Time; +import org.apache.kafka.coordinator.group.api.streams.StreamsGroupTopologyDescriptionPlugin; + +import java.util.Optional; + +/** + * Broker-level component that owns everything tied to the streams-group topology + * description plugin: the configured plugin reference, the per-group re-solicitation + * back-off, and the heartbeat-path gate that asks clients to push their topology. + * + * <p>This class is broker-level (one instance per {@code GroupCoordinatorService}); the + * back-off map is keyed by {@code groupId} and shared across all partitions hosted on the + * broker. State here is intentionally non-timeline and non-replayed: it is rebuilt from + * scratch on broker restart, and the persisted {@code StoredDescriptionTopologyEpoch} / + * {@code FailedDescriptionTopologyEpoch} fields on each streams group drive convergence + * after a restart. + */ +public class StreamGroupTopologyDescriptionManager implements AutoCloseable { Review Comment: @frankvicky StreamGroupTopologyDescriptionManager — missing the "s" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
