lucasbru commented on code in PR #22551:
URL: https://github.com/apache/kafka/pull/22551#discussion_r3415129405
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -633,6 +650,7 @@ public CompletableFuture<StreamsGroupHeartbeatResult>
streamsGroupHeartbeat(
"streams-group-heartbeat",
topicPartitionFor(request.groupId()),
coordinator -> coordinator.streamsGroupHeartbeat(context, request)
+ ).thenApply(result ->
streamGroupTopologyDescriptionManager.maybeSetTopologyDescriptionRequired(result,
request.groupId())
Review Comment:
The POC gates this on `requestVersion >= 1` (passes
`context.requestVersion()` and returns early below v1).
`TopologyDescriptionRequired` is a v1-only field, so for a v0 client we end up
arming and growing the per-group backoff while the flag itself gets dropped at
serialization. Was dropping the version check intentional, or should we pass
`context.requestVersion()` through?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
