anton-liauchuk commented on code in PR #20384:
URL: https://github.com/apache/kafka/pull/20384#discussion_r3636355267


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java:
##########
@@ -401,6 +401,10 @@ public boolean connectorOffsetsTopicsPermitted() {
         return false;
     }
 
+    public boolean internalTopicsCreationEnabled() {
+        return false;

Review Comment:
   The method is needed in `WorkerConfig` because 
KafkaTopicBasedBackingStore.topicInitializer() takes a WorkerConfig and calls 
internalTopicsCreationEnabled() on it. Removing it would require a cast 
somewhere in existing logic. The default value modified to `true`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to