chia7712 commented on code in PR #20384:
URL: https://github.com/apache/kafka/pull/20384#discussion_r3655836282
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java:
##########
@@ -427,6 +435,12 @@ private static ConfigDef config(Crypto crypto) {
WORKER_UNSYNC_BACKOFF_MS_DEFAULT,
ConfigDef.Importance.MEDIUM,
WORKER_UNSYNC_BACKOFF_MS_DOC)
+ .define(
+ INTERNAL_TOPICS_AUTOMATIC_CREATION_ENABLE_CONFIG,
+ Type.BOOLEAN,
+ INTERNAL_TOPICS_AUTOMATIC_CREATION_ENABLE_DEFAULT,
+ ConfigDef.Importance.HIGH,
Review Comment:
I'm wondering about setting this to `Importance.HIGH`. Given that it
defaults to true and most users probably won't need to touch it, would `MEDIUM`
or `LOW` be a better fit?
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java:
##########
@@ -187,6 +188,13 @@ public final class DistributedConfig extends WorkerConfig {
public static final String CONNECT_PROTOCOL_DOC = "Compatibility mode for
Kafka Connect Protocol";
public static final String CONNECT_PROTOCOL_DEFAULT =
ConnectProtocolCompatibility.SESSIONED.toString();
+
+ public static final String
INTERNAL_TOPICS_AUTOMATIC_CREATION_ENABLE_CONFIG =
"internal.topics.automatic.creation.enable";
+ private static final String INTERNAL_TOPICS_AUTOMATIC_CREATION_ENABLE_DOC
= "Whether to automatically create internal topics used by Connect. "
+ + "This includes the offset, config, and status topics, as well as
connector-specific offset topics "
+ + "configured via 'offsets.storage.topic' in the source connector
configuration.";
+ public static final Boolean
INTERNAL_TOPICS_AUTOMATIC_CREATION_ENABLE_DEFAULT = true;
Review Comment:
`Boolean` -> `boolean`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
