anton-liauchuk commented on code in PR #20384:
URL: https://github.com/apache/kafka/pull/20384#discussion_r3655524889
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java:
##########
@@ -172,12 +176,14 @@ public final class DistributedConfig extends WorkerConfig
{
* <code>status.storage.partitions</code>
*/
public static final String STATUS_STORAGE_PARTITIONS_CONFIG =
STATUS_STORAGE_PREFIX + PARTITIONS_SUFFIX;
+ public static final int STATUS_STORAGE_PARTITIONS_DEFAULT = 5;
private static final String STATUS_STORAGE_PARTITIONS_CONFIG_DOC = "The
number of partitions used when creating the status storage topic";
/**
* <code>status.storage.replication.factor</code>
*/
public static final String STATUS_STORAGE_REPLICATION_FACTOR_CONFIG =
STATUS_STORAGE_PREFIX + REPLICATION_FACTOR_SUFFIX;
+ public static final short STATUS_STORAGE_REPLICATION_FACTOR_DEFAULT = 3;
Review Comment:
Fixed, thanks! Removed the public default constants. Defaults are now inline
literals in both `DistributedConfig.config()` and
`ConnectInternalTopics.InternalTopicsConfig`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
