arnabnandy7 commented on code in PR #22989:
URL: https://github.com/apache/kafka/pull/22989#discussion_r3676943408
##########
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java:
##########
@@ -34,6 +34,44 @@
public abstract class AbstractResponse implements AbstractRequestResponse {
public static final int DEFAULT_THROTTLE_TIME = 0;
+ private static final Map<ApiKeys, Short> POST_KIP_219_VERSION =
Map.ofEntries(
+ Map.entry(ApiKeys.PRODUCE, (short) 6),
Review Comment:
@junrao my understanding is that these entries represent the fixed
historical version where client-side throttling began, rather than the
currently supported or non-deprecated version range.
Deprecating an older version should therefore not require updating this map.
An entry may become redundant as the minimum supported version advances, but it
would remain behaviorally correct.
That said, if you prefer avoiding the duplicated protocol-version metadata
entirely, I’m happy to retain the version-specific overrides in the response
classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
