chia7712 commented on code in PR #22989:
URL: https://github.com/apache/kafka/pull/22989#discussion_r3845469340
##########
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java:
##########
@@ -34,6 +34,46 @@
public abstract class AbstractResponse implements AbstractRequestResponse {
public static final int DEFAULT_THROTTLE_TIME = 0;
+ // These values represent immutable historical version boundaries for
KIP-219 client-side throttling.
Review Comment:
I'm wondering if we could move this into its own file to protect it from
unexpected changes. `AbstractResponse` will keep being touched during normal
development, but the new file should never need to change after this PR (except
for the license header), so any future diff to it would be an obvious signal in
review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
