chia7712 commented on code in PR #22989:
URL: https://github.com/apache/kafka/pull/22989#discussion_r3691679749
##########
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java:
##########
@@ -34,6 +34,44 @@
public abstract class AbstractResponse implements AbstractRequestResponse {
public static final int DEFAULT_THROTTLE_TIME = 0;
+ private static final Map<ApiKeys, Short> POST_KIP_219_VERSION =
Map.ofEntries(
+ Map.entry(ApiKeys.PRODUCE, (short) 6),
Review Comment:
could you add comment for the `POST_KIP_219_VERSION`? For example:
`
These values represent immutable historical version boundaries for KIP-219
client-side throttling. They do not change when older API versions are
deprecated.
`
> is this approach better?
I love this approach because it is more simple and readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
