Nikita-Shupletsov commented on code in PR #23093:
URL: https://github.com/apache/kafka/pull/23093#discussion_r3737640685
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -580,9 +620,6 @@ private void removeTask(final TaskId taskId,
} catch (final StreamsException streamsException) {
handleStreamsExceptionWithTask(streamsException, taskId);
future.completeExceptionally(streamsException);
- } catch (final RuntimeException runtimeException) {
Review Comment:
when we receive a StreamsException we shutdown the stream thread as well.
it's just that a StreamsException is an expected exception, so we deal with it
gracefully: we put the task in the list of failed tasks and then the
TaskManager will deal with them in maybeThrowTaskExceptions. so we expect that
something will throw a StreamsException and we have a graceful handling of it.
We don't expect other kinds of exceptions/errors, so we treat them as a stop
the world sort of event
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
