mjsax commented on code in PR #23093:
URL: https://github.com/apache/kafka/pull/23093#discussion_r3737193156
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -716,9 +718,18 @@ private Task checkIfTaskFailed(final
StateUpdater.RemovedTaskResult removedTaskR
private StateUpdater.RemovedTaskResult waitForFuture(final TaskId taskId,
final
CompletableFuture<StateUpdater.RemovedTaskResult> future) {
- final StateUpdater.RemovedTaskResult removedTaskResult;
+ StateUpdater.RemovedTaskResult removedTaskResult;
try {
- removedTaskResult = future.get(5, TimeUnit.MINUTES);
+ long minutesWaited = 0L;
+ while (true) {
Review Comment:
```suggestion
while (removedTaskResult == null) {
```
This avoid the `break;` and makes the code more readable, as it clearly
expressed we are waiting until we get a result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
