mjsax commented on code in PR #23093:
URL: https://github.com/apache/kafka/pull/23093#discussion_r3737086855
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -580,9 +620,6 @@ private void removeTask(final TaskId taskId,
} catch (final StreamsException streamsException) {
handleStreamsExceptionWithTask(streamsException, taskId);
future.completeExceptionally(streamsException);
- } catch (final RuntimeException runtimeException) {
Review Comment:
> because we don't stop the thread on StreamsException
We don't? This sounds off? A StreamsException is supposed to be treated as
fatal... I find this a little bit confusing. Maybe I am missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
