lianetm commented on code in PR #23014:
URL: https://github.com/apache/kafka/pull/23014#discussion_r3778695514
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1995,9 +1993,10 @@ private Fetch<K, V> pollForFetches(Timer timer) {
Set<TopicPartition> partitions =
subscriptions.assignedPartitions();
if (partitions.isEmpty()) {
- // If there aren't any assigned partitions, this could mean
that this consumer's group membership
- // has not been established or assignments have been removed
and not yet reassigned. In either case,
- // reduce the poll time for the fetch buffer wait.
+ // If there are no assigned partitions, group membership may
not yet be established, assignments
+ // may have been revoked and not yet reassigned, bootstrap DNS
resolution may still be in progress,
+ // or manual assignment may not have happened yet. In any of
these cases, reduce the fetch buffer
+ // wait time.
Review Comment:
this reads weird now, missing words? Maybe rearrange
```suggestion
// If there are no assigned partitions, reduce the fetch
buffer wait time
// This could be the case if xxxx.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
