andrewgrantcflt commented on code in PR #23245:
URL: https://github.com/apache/kafka/pull/23245#discussion_r3838530467
##########
raft/src/main/java/org/apache/kafka/raft/KRaftConfigs.java:
##########
@@ -69,6 +69,12 @@ public class KRaftConfigs {
public static final long
CONTROLLER_PERFORMANCE_ALWAYS_LOG_THRESHOLD_MS_DEFAULT = 2000;
public static final String
CONTROLLER_PERFORMANCE_ALWAYS_LOG_THRESHOLD_MS_DOC = "We will log an error
message about controller events that take longer than this threshold.";
+ public static final String CONTROLLER_MAX_PARTITIONS_PER_BATCH_CONFIG =
"controller.max.partitions.per.batch";
Review Comment:
I considered naming the config
`controller.max.partitions.per.create.topics.batch` as well. As of now, this
config is only used when handling `CREATE_TOPICS` requests so arguably that
name may be clearer. `controller.max.partitions.per.batch` is a bit generic and
could imply it is used for other RPCs, but maybe that's better if we want to
reuse this config in the future, for example for `CREATE_PARTITIONS`?
Curious to hear other folks' opinions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
