andrewgrantcflt commented on PR #23245: URL: https://github.com/apache/kafka/pull/23245#issuecomment-5396826533
> Thanks for the PR. I don't like adding the config without a KIP, but this is an internal-only config and it is making a hard-coded limit configurable. I reckon it sneaks in under the KIP bar :) > > I do suggest making it a bit more general-purposes in the ReplicationControlManager. For example, `deleteTopics` and others limit the request size to `MAX_RECORDS_PER_USER_OP`, which is also 10000. Aren't these essentially the same thing, checking that the user operation is not too complex for the controller to handle? Let me know if that makes sense too. @AndrewJSchofield and I chatted. I am going to close this PR because it's a bit controversial adding a config without a KIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
