andrewgrantcflt commented on PR #23245: URL: https://github.com/apache/kafka/pull/23245#issuecomment-5413443544
@AndrewJSchofield I updated all the managers to require the max records per batch value be set. If not set, their `build` method will fail with an error. It felt a bit unclean for each of them to set a default; I prefer the default really is defined in one place, namely in `KRaftConfigs`. Each manager technically could set a default by doing something like ``` private int maxRecordsPerBatch = KRaftConfigs.CONTROLLER_MAX_RECORDS_PER_BATCH_DEFAULT ``` but I still don't love that. In my opinion the code in `KafkaConfig` ``` val controllerMaxRecordsPerBatch: Int = getInt(KRaftConfigs.CONTROLLER_MAX_RECORDS_PER_BATCH_CONFIG) ``` is responsible for knowing how to use the default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
