squah-confluent commented on code in PR #23121:
URL: https://github.com/apache/kafka/pull/23121#discussion_r3846109796
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
Review Comment:
We could rename this to `validateOnController`?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -477,9 +477,28 @@ public static void validateNames(Map<String, String>
newGroupConfig) {
}
}
+ /**
+ * Check that the selected task assignor is one of the assignors
registered on the broker.
+ * Validated separately from {@link #validate} because the registry of
assignors only exists on
+ * brokers, which are the nodes that run the group coordinator.
+ *
+ * @param assignorName The requested assignor name, as an
unparsed config value.
+ * @param registeredAssignorNames The names of the assignors registered on
the broker.
+ */
+ public static void validateAssignorName(String assignorName, List<String>
registeredAssignorNames) {
Review Comment:
We could declare a `validateOnBroker` method taking the same signature as
`GroupConfig.validate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
