dajac commented on code in PR #23121:
URL: https://github.com/apache/kafka/pull/23121#discussion_r3852680834
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -628,16 +664,6 @@ private static void validateValues(
groupCoordinatorConfig.streamsGroupMaxWarmupReplicas()
);
- // The selected streams assignor must be one of the assignors
registered on the broker.
- if (parsed.containsKey(STREAMS_ASSIGNOR_NAME_CONFIG)) {
- String assignorName = (String)
parsed.get(STREAMS_ASSIGNOR_NAME_CONFIG);
- List<String> registeredAssignors =
groupCoordinatorConfig.streamsGroupAssignorNames();
- if (!registeredAssignors.contains(assignorName)) {
- throw new
InvalidConfigurationException(STREAMS_ASSIGNOR_NAME_CONFIG + " '" +
assignorName +
- "' is not a registered task assignor. Registered assignors
are: " + registeredAssignors + ".");
- }
- }
Review Comment:
I think that we have an issue on the upgrade path here. If the controllers
are updated to the new version before the brokers are (the recommended way), we
end up with a cluster where `STREAMS_ASSIGNOR_NAME_CONFIG` is not validated at
all, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
