chia7712 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4062992415
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
[KIP-1252](https://github.com/apache/kafka/pull/23310/...) added a flag to
make the ZK behavior compatible with KRaft, and now this PR changes the KRaft
behavior that the flag emulates. I'm not sure how users upgrading from 3.9 to
4.x with alter.config.policy.kraft.compatibility.enable=true will handle that.
Maybe a better way is to leave configs() as it is and have a KIP to add two
methods to RequestMetadata: one returning the deleted keys, and one returning
the configs without null values. That gives policies an explicit way to see
deletions without changing the existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
