arnabnandy7 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4064527508
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
@chia7712 thanks for catching the KIP-1252 compatibility issue. I hadn’t
accounted for clusters using the 3.9.2 flag to match KRaft’s existing behavior.
I’ve opened a follow-up PR (#23545) that restores that behavior and adds a
test covering DELETE for both unset and stored topic configs, as well as an
unset broker config. I also clarified the `configs()` Javadoc. The original
inconsistency remains, but I agree that exposing deletions explicitly is better
handled through a separate KIP than by changing what existing policies receive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
