chia7712 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4067653079
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
I don't think #23545 fully addresses the issue I mentioned. First, changing
the public interface generally requires a KIP. Second, this seems to conflict
with the compatibility goals introduced by KIP-1252.
In my opinion, it might be safer to revert this PR and propose a KIP to
properly accommodate the changes in #23543. @edoardocomar @arnabnandy7 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
