AndrewJSchofield commented on code in PR #23544:
URL: https://github.com/apache/kafka/pull/23544#discussion_r4064946037
##########
clients/src/main/resources/common/message/RequestHeader.json:
##########
@@ -39,6 +41,8 @@
// Since the client is sending the ApiVersionsRequest in order to discover
what
// versions are supported, the client does not know the best version to
use.
{ "name": "ClientId", "type": "string", "versions": "1+",
"nullableVersions": "1+", "flexibleVersions": "none",
- "about": "The client ID string." }
+ "about": "The client ID string." },
Review Comment:
Sorry for being hyper-picky, but the `about` strings in the KIP are part of
the specification. These details get scrutinized in the KIP discussion, so
please use the details verbatim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
