alanlau28 commented on code in PR #23544:
URL: https://github.com/apache/kafka/pull/23544#discussion_r4083860455
##########
generator/src/test/java/org/apache/kafka/message/HeaderVersionsTest.java:
##########
@@ -42,8 +42,8 @@ private static MessageSpec headerSpec(String name, String
validVersions, String
"', 'flexibleVersions': '" + flexibleVersions + "'}");
}
- // The real RequestHeader / ResponseHeader shapes: request header 1-2
(flexible from 2),
- // response header 0-1 (flexible from 1).
+ // Synthetic header shapes. The request header stops at v2, below the real
schema, so that
Review Comment:
I bumped the request header in the tests to 1-3, I thought about it and
didn't make much sense to keep it at v2 given v3 is introduced. These tests are
for the validation code against a mock schema, when v4 is introduced, this
check will need to get bumped to v4 as well to mimic the production code.
Apologies 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
