alanlau28 commented on code in PR #23544:
URL: https://github.com/apache/kafka/pull/23544#discussion_r4106646444
##########
clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java:
##########
@@ -188,6 +191,15 @@ connectionSetupTimeoutMsTest,
connectionSetupTimeoutMaxMsTest, time, false, new
MetadataRecoveryStrategy.NONE, bootstrapConfiguration, false);
}
+ private NetworkClient createNetworkClientWithClientInstanceId(Uuid
clientInstanceId) {
Review Comment:
This is a good point.
What I did was require a `clientInstanceId` to be passed when the
producer/consumer/admin calls the long constructor of `NetworkClient`. For
callers of the short constructor, `NetworkClient` will generate its own
`clientInstanceId`. The tests are modified to cover this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
